From 0000000000000000000000000000000000000000 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ond=C5=99ej=20Jirman?= Date: Fri, 22 Oct 2021 19:52:49 +0200 Subject: media: ov5640: Improve error reporting Some probe errors are currently not reported. Report them properly. Signed-off-by: Ondrej Jirman --- drivers/media/i2c/ov5640.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index b624153dc057..4ccd92b728d8 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c @@ -3911,8 +3911,10 @@ static int ov5640_probe(struct i2c_client *client) return ret; ret = ov5640_get_regulators(sensor); - if (ret) + if (ret) { + dev_err_probe(dev, ret, "Failed to get regulators\n"); goto entity_cleanup; + } mutex_init(&sensor->lock); @@ -3921,8 +3923,10 @@ static int ov5640_probe(struct i2c_client *client) goto entity_cleanup; ret = v4l2_async_register_subdev_sensor(&sensor->sd); - if (ret) + if (ret) { + dev_err_probe(dev, ret, "Failed to register sensor\n"); goto free_ctrls; + } pm_runtime_enable(dev); pm_runtime_set_autosuspend_delay(dev, 1000); -- Armbian